Allow triggering suggestions without prefix space #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any progress on reviewing this? Anything I should change or is there a reason this wouldn't be accepted at all? |
|
Thanks! Sorry for that delay. |
|
Thanks for the quick release also! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
suggestionextension only allows triggering the suggestions dropdown if the suggestion character is prefixed by space. This of course makes sense for @mentions but for some other use cases it is desirable to also trigger suggestions dropdown if suggestions character is not prefixed by space (e.g. with variables inside the text).Already requested in:
findSuggestionMatch， There should be a configuration to configure whether to match the prefix #1384